AST: Retire subclasses of AvailabilitySpec
#79354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
slavapestov,
hborla,
xedin,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight and
rintaro
as code owners
|
@swift-ci please test |
tshortli
force-pushed
the
retire-availability-spec-subclasses
branch
from
a7a0fad to
670084a
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate everything that
AvailabilitySpecmodels into a single class, instead of having subclasses that model each flavor of spec. Soon, anAvailabilitySpecwill only carry the raw availability domain identifier as a parsed string and the availability domain instance will need to be queried using a request that takes aDeclContext, so we will not be able to distinguish between flavors of spec during parsing. Most availability spec related diagnostics will need to move from parsing to type checking.Builds on #79312.
NFC.