Runtimes: add -nostdlibimport to the runtime build
#79443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
requested review from
etcwilde,
edymtt and
justice-adams-apple
as code owners
|
@swift-ci please smoke test |
etcwilde
reviewed
Feb 17, 2025
|
Yeah, that seems reasonable. |
If the compiler being used to build the runtime is from a complete toolchain, we may inadvertently pick up runtime from the previous build rather than the just built Swift Core library. Pass `-nostdlibimport` to ensure that we do not search the default search paths when building and use the locally built swiftCore.
compnerd
force-pushed
the
hermermetic
branch
from
aa47859 to
53c70df
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
etcwilde
approved these changes
Feb 18, 2025
edymtt
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the compiler being used to build the runtime is from a complete toolchain, we may inadvertently pick up runtime from the previous build rather than the just built Swift Core library. Pass
-nostdlibimportto ensure that we do not search the default search paths when building and use the locally built swiftCore.