Skip to content

Fix lifetime inference with older .swiftinterface files. #80156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 20, 2025

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Mar 20, 2025

This was fix was accidentally not include in the previous commit, which breaks older .swiftinterface files without it:

commit 75ba7a8
Merge: befc15e d41c4d4
Author: Andrew Trick [email protected]
Date: Wed Mar 19 18:22:35 2025

Merge pull request #80064 from atrick/lifetime-inference

LifetimeDependence: implement strict type checking

@atrick atrick enabled auto-merge March 20, 2025 04:06
@atrick
Copy link
Contributor Author

atrick commented Mar 20, 2025

@swift-ci smoke test

atrick added 4 commits March 19, 2025 22:22
This was fix was accidentally not include in the previous commit,
which breaks older .swiftinterface files without it:

commit 75ba7a8
Merge: befc15e d41c4d4
Author: Andrew Trick <[email protected]>
Date:   Wed Mar 19 18:22:35 2025

    Merge pull request swiftlang#80064 from atrick/lifetime-inference

    LifetimeDependence: implement strict type checking
Inference used to accept explicit setters on non-Escapable 'self'
Restore this behavior under:
-enable-experimental-lifetime-dependence-inference
Ensure that we don't regress inference under
-Xfrontend -enable-experimental-lifetime-dependence-inference

Which is the default mode for .swiftinterface.
@atrick atrick requested a review from jckarter as a code owner March 20, 2025 05:39
@atrick
Copy link
Contributor Author

atrick commented Mar 20, 2025

@swift-ci smoke test

@atrick atrick merged commit 44b0d5d into swiftlang:main Mar 20, 2025
3 checks passed
@atrick atrick deleted the fix-interface branch March 20, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant