[SILOptimizer] Turn "is self-recursive" check into analysis #80236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The body of a function has to be re-analyzed for every call site of the function, which is very expensive and if the body is not changed would produce the same result. This takes about ~10% from swift-syntax overall build time in release configuration.
|
@swift-ci please test |
|
@swift-ci apple silicon benchmark |
|
@swift-ci benchmark |
|
@swift-ci apple silicon benchmark |
|
Apple silicon benchmark fails with: |
|
Thanks @xedin 😍 ! |
CodaFi
reviewed
Mar 25, 2025
| // Force the compiler to generate the destructor in this C++ file. | ||
| // Otherwise it can happen that it is generated in a SwiftCompilerSources module | ||
| // and that results in unresolved-symbols linker errors. | ||
| IsSelfRecursive::~IsSelfRecursive() = default; |
There was a problem hiding this comment.
It's not just the destructor right, isn't this the way to convince clang to place the vtable in this TU?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The body of a function has to be re-analyzed for every call site of the function, which is very expensive and if the body is not changed would produce the same result.
This takes about ~10% from swift-syntax overall build time in release configuration.