-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[SILOptimizer] Turn "is self-recursive" check into analysis #80236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 changes: 75 additions & 0 deletions
75
include/swift/SILOptimizer/Analysis/IsSelfRecursiveAnalysis.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| //===--- IsSelfRecursiveAnalysis.h ----------------------------------------===// | ||
| // | ||
| // This source file is part of the Swift.org open source project | ||
| // | ||
| // Copyright (c) 2014 - 2025 Apple Inc. and the Swift project authors | ||
| // Licensed under Apache License v2.0 with Runtime Library Exception | ||
| // | ||
| // See https://swift.org/LICENSE.txt for license information | ||
| // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #ifndef SWIFT_SILOPTIMIZER_ISSELFRECURSIVEANALYSIS_H | ||
| #define SWIFT_SILOPTIMIZER_ISSELFRECURSIVEANALYSIS_H | ||
|
|
||
| #include "swift/SILOptimizer/Analysis/Analysis.h" | ||
|
|
||
| namespace swift { | ||
| class SILFunction; | ||
|
|
||
| class IsSelfRecursive { | ||
| const SILFunction *f; | ||
| bool didComputeValue = false; | ||
| bool isSelfRecursive = false; | ||
|
|
||
| void compute(); | ||
|
|
||
| public: | ||
| IsSelfRecursive(const SILFunction *f) : f(f) {} | ||
|
|
||
| ~IsSelfRecursive(); | ||
|
|
||
| bool isComputed() const { return didComputeValue; } | ||
|
|
||
| bool get() { | ||
| if (!didComputeValue) { | ||
| compute(); | ||
| didComputeValue = true; | ||
| } | ||
| return isSelfRecursive; | ||
| } | ||
|
|
||
| SILFunction *getFunction() { return const_cast<SILFunction *>(f); } | ||
| }; | ||
|
|
||
| class IsSelfRecursiveAnalysis final | ||
| : public FunctionAnalysisBase<IsSelfRecursive> { | ||
| public: | ||
| IsSelfRecursiveAnalysis() | ||
| : FunctionAnalysisBase<IsSelfRecursive>( | ||
| SILAnalysisKind::IsSelfRecursive) {} | ||
|
|
||
| IsSelfRecursiveAnalysis(const IsSelfRecursiveAnalysis &) = delete; | ||
| IsSelfRecursiveAnalysis &operator=(const IsSelfRecursiveAnalysis &) = delete; | ||
|
|
||
| static SILAnalysisKind getAnalysisKind() { | ||
| return SILAnalysisKind::IsSelfRecursive; | ||
| } | ||
|
|
||
| static bool classof(const SILAnalysis *s) { | ||
| return s->getKind() == SILAnalysisKind::IsSelfRecursive; | ||
| } | ||
|
|
||
| std::unique_ptr<IsSelfRecursive> newFunctionAnalysis(SILFunction *f) override { | ||
| return std::make_unique<IsSelfRecursive>(f); | ||
| } | ||
|
|
||
| bool shouldInvalidate(SILAnalysis::InvalidationKind k) override { | ||
| return k & InvalidationKind::Calls; | ||
| } | ||
| }; | ||
|
|
||
| } // namespace swift | ||
|
|
||
| #endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| //===--- IsSelfRecursiveAnalysis.cpp --------------------------------------===// | ||
| // | ||
| // This source file is part of the Swift.org open source project | ||
| // | ||
| // Copyright (c) 2014 - 2025 Apple Inc. and the Swift project authors | ||
| // Licensed under Apache License v2.0 with Runtime Library Exception | ||
| // | ||
| // See https://swift.org/LICENSE.txt for license information | ||
| // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #include "swift/SILOptimizer/Analysis/IsSelfRecursiveAnalysis.h" | ||
| #include "swift/SIL/ApplySite.h" | ||
| #include "swift/SIL/SILBasicBlock.h" | ||
| #include "swift/SIL/SILFunction.h" | ||
| #include "swift/SIL/SILInstruction.h" | ||
|
|
||
| using namespace swift; | ||
|
|
||
| // Force the compiler to generate the destructor in this C++ file. | ||
| // Otherwise it can happen that it is generated in a SwiftCompilerSources module | ||
| // and that results in unresolved-symbols linker errors. | ||
| IsSelfRecursive::~IsSelfRecursive() = default; | ||
|
|
||
| void IsSelfRecursive::compute() { | ||
| isSelfRecursive = false; | ||
|
|
||
| for (auto &BB : *getFunction()) { | ||
| for (auto &I : BB) { | ||
| if (auto Apply = FullApplySite::isa(&I)) { | ||
| if (Apply.getReferencedFunctionOrNull() == f) { | ||
| isSelfRecursive = true; | ||
| return; | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| //===----------------------------------------------------------------------===// | ||
| // Main Entry Point | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| SILAnalysis *swift::createIsSelfRecursiveAnalysis(SILModule *) { | ||
| return new IsSelfRecursiveAnalysis(); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not just the destructor right, isn't this the way to convince clang to place the vtable in this TU?