[cxx-interop] Import parameterized public ctors of C++ foreign ref types as Swift Initializer #80449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahadnayyar
force-pushed
the
cxx-frt-constructors-params
branch
from
fa97b38 to
96518c0
Compare
|
Note: Default arguments are still not supported for both default and parameterized ctors |
fahadnayyar
requested review from
zoecarver,
egorzhdan,
Xazax-hun,
j-hui,
susmonteiro,
hnrklssn,
beccadax and
ian-twilightcoder
as code owners
Xazax-hun
reviewed
Apr 2, 2025
j-hui
reviewed
Apr 3, 2025
|
@swift-ci please smoke test |
Xazax-hun
reviewed
Apr 4, 2025
Xazax-hun
reviewed
Apr 4, 2025
| struct __attribute__((swift_attr("import_reference"))) | ||
| __attribute__((swift_attr("retain:Retain18"))) | ||
| __attribute__((swift_attr("release:Release18"))) NoIdentifierInCtorParam { | ||
| public: |
There was a problem hiding this comment.
Would be nice to have some tests with constructors of user defined types that have user defined copy/move ctors.
Xazax-hun
reviewed
Apr 4, 2025
|
Enabling auto merge after addressing all the comments on this patch. I can think of only 2 things right now which can be addressed in a follow up patch:
|
Xazax-hun
approved these changes
Apr 7, 2025
| "Unable to synthesize `new` expression for c++ foreign reference type"); | ||
| auto *synthNewExpr = cast<clang::CXXNewExpr>(synthNewExprResult.get()); | ||
|
|
||
| clang::ReturnStmt *synthRetStmt = clang::ReturnStmt::Create( |
There was a problem hiding this comment.
Nit: I wonder if we want to use Sema::BuildReturnStmt here, and add the SFNAETrap to all of the sema calls (could be the same trap for all the Build* calls).
Xazax-hun
reviewed
Apr 7, 2025
|
@swift-ci please smoke test |
|
Enabling auto merge after addressing all the comments on this patch. I can think of only these minor things which can be addressed in follow up patches later:
|
fahadnayyar
added a commit
that referenced
this pull request
Apr 10, 2025
…pes as Swift Initializer (#80449) Extends PR #79986 by adding support for calling parameterized C++ initializers from Swift. This patch synthesizes static factory methods corresponding to C++ parameterized constructors, allowing Swift to call them as Swift initializers (e.g., init(_:), init(_:_:), etc.). This patch also aded tests and logic to make sure that we emit no additional diagnostics when a C++ foreign ref type is just referred from Swift and its initializer is not explicitly called. rdar://148285251
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends PR #79986 by adding support for calling parameterized C++ initializers from Swift. This patch synthesizes static factory methods corresponding to C++ parameterized constructors, allowing Swift to call them as Swift initializers (e.g.,
init(_:),init(_:_:), etc.).rdar://148285251