🍒 [6.2] [cxx-interop] Import public constructor of C++ foreign reference types as Swift initializers #80715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pes as Swift Initializer (#80449) Extends PR #79986 by adding support for calling parameterized C++ initializers from Swift. This patch synthesizes static factory methods corresponding to C++ parameterized constructors, allowing Swift to call them as Swift initializers (e.g., init(_:), init(_:_:), etc.). This patch also aded tests and logic to make sure that we emit no additional diagnostics when a C++ foreign ref type is just referred from Swift and its initializer is not explicitly called. rdar://148285251
…ssCXXForeignReferenceTypeInitializers to be an opt-out flag Turning the feature "ctor of C++ foreign reference types is callable as Swift Initializers" on by default. rdar://148285972
|
@swift-ci please test |
Xazax-hun
approved these changes
Apr 10, 2025
This comment was marked as resolved.
This comment was marked as resolved.
fahadnayyar
added
c++ interop
|
@swift-ci please test macOS |
airspeedswift
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: In this change we are enabling Swift to construct C++ foreign reference types directly by calling an initializer, without needing to create wrapper functions in C++ that would construct the object and return it. The Swift compiler would automatically allocate using new operator and call the C++ constructor of the type via a compiler synthesized static factory.
Issue: rdar://131557219
Risk: Low. This doesn't impact existing code but provides a new functionality. The risk of this patch is that the automatic initializers are synthesized for all foreign references types regardless of whether they are used or not. We take enough precaution before we start the synthesis of any AST node to ensure that the synthesized code will compile correctly.
Testing: Added tests to test suite and manually tested by using this on some adopter projects
Original PRs: #79986, #80449, #80659
Reviewer: @Xazax-hun @j-hui