Preparations for special names #8053
Conversation
|
Please test with following pull request: @swift-ci Please test |
|
Build failed |
|
Forgot to push the updated version of the LLDB changes, let's try Linux again. Please test with following pull request: @swift-ci Please test Linux platform |
ahoppen
force-pushed
the
preparation-declname
branch
from
dde2a96 to
0ea37d3
Compare
|
Resolved some merge conflicts. @swift-ci Please smoke test |
ahoppen
force-pushed
the
preparation-declname
branch
from
0ea37d3 to
dd7139e
Compare
|
Resolved some new merge conflicts Please test with following pull request: @swift-ci Please smoke test |
|
@jrose-apple Just a friendly ping |
ahoppen
force-pushed
the
preparation-declname
branch
2 times, most recently
from
7601957 to
124bc5f
Compare
|
Resolved another merge conflict Please test with following pull request: @swift-ci Please smoke test |
ahoppen
force-pushed
the
preparation-declname
branch
from
124bc5f to
a921083
Compare
|
More merge conflicts resolved. Please test with following pull request: @swift-ci Please smoke test |
|
Linux failure seemed unrelated, let's try again. Please test with following pull request: @swift-ci Please test Linux platform |
|
Build failed |
ahoppen
force-pushed
the
preparation-declname
branch
from
a921083 to
c5bb6b7
Compare
|
Next merge conflict. Please test with following pull request: @swift-ci Please smoke test |
|
@jrose-apple It would be great if you (or someone else) could review this so we can get it merged before the final Swift 4 rush starts |
ahoppen
force-pushed
the
preparation-declname
branch
from
c5bb6b7 to
bd1b12d
Compare
|
Resolved some merge conflicts once again. Please test with following pull request: @swift-ci Please smoke test |
Special names will in the future represent names that don't have a surface language identifier like subscript. For this, change the backing type of DeclName to a new type DeclBaseName that will later be able to represent special names. ValueDecls may therefore no longer have an identifier name. Thus we move the getName method from ValueDecl to the subtypes that are guaranteed to have identifier names. Since special names have not been introduced yet, TODOs are left where handling of these will most likely be necessary. Furthermore the SwiftLookupTable will needs to be changed to handle special names.
ahoppen
force-pushed
the
preparation-declname
branch
from
d7f59e3 to
161b30f
Compare
|
Once again a minor merge conflict Please test with following pull request: @swift-ci Please smoke test |
Special names will in the future represent names that don't have a surface language identifier like subscript.
For this, change the backing type of DeclName to a new type DeclBaseName that will later be able to represent special names.
ValueDecls may therefore no longer have an identifier name. Thus we move the getName method from ValueDecl to the subtypes that are guaranteed to have identifier names.
Since special names have not been introduced yet, TODOs are left where handling of these will most likely be necessary. Furthermore the SwiftLookupTable will needs to be changed to handle special names.
These TODOs will be addressed in PRs for subsequent commits of #6848. If it would make it easier to reason about the code, we can also do this together with the next commit, but that would make it one big (~1000 lines) PR instead of two small-ish ones (~500 lines)