Preparations for special names #9967
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Special names will in the future represent names that don't have a surface language identifier like subscript. For this, change the backing type of DeclName to a new type DeclBaseName that will later be able to represent special names. ValueDecls may therefore no longer have an identifier name. Thus we move the getName method from ValueDecl to the subtypes that are guaranteed to have identifier names. Since special names have not been introduced yet, TODOs are left where handling of these will most likely be necessary. Furthermore the SwiftLookupTable will needs to be changed to handle special names.
|
I'm moving forward with this now because I want it to be easy to cherry-pick things from the master branch to the 4.0 branch. apple/swift-lldb#165 |
|
Whoops, I may have misunderstood the purpose of Alex's newer patches. We might have a more incremental version to land instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8053, rebased on @ahoppen's behalf.
This is a big change, splitting Identifier out into Identifier and DeclBaseName in preparation for
subscript(and eventuallyinitanddeinit) no longer being plain old identifiers. It's entirely possible Alex and I have changed something incorrectly here, picking either Identifier or DeclBaseName where the other would have been more appropriate. Still, this patch alone should not cause any regressions or changes in behavior; the only places where we have actually done something differently are in debugging output (usually a switch to print a full name instead of just a base name).