Skip to content

embedded: fix two problems in the SILLinker #80530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025

Conversation

eeckstein
Copy link
Contributor

  • make sure to de-serialize base protocol witness tables
  • de-serialize Executor witness tables for the xExecutorRef builtins

Fixes unresolved symbol linker errors in embedded mode.
rdar://148538336

@eeckstein eeckstein requested a review from kubamracek April 4, 2025 08:13
@eeckstein eeckstein requested a review from jckarter as a code owner April 4, 2025 08:13
@eeckstein eeckstein removed the request for review from jckarter April 4, 2025 08:13
@eeckstein
Copy link
Contributor Author

@swift-ci smoke test

Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙇

@MaxDesiatov MaxDesiatov added SIL embedded Embedded Swift labels Apr 4, 2025
…embedded mode

Fixes unresolved symbol linker errors or compiler crashes
rdar://148538336
…builtins

Fixes unresolved symbol linker errors in embedded mode.
rdar://148538336
@eeckstein
Copy link
Contributor Author

@swift-ci smoke test

@eeckstein eeckstein merged commit 6f68a86 into swiftlang:main Apr 4, 2025
3 checks passed
@eeckstein eeckstein deleted the fix-sil-linker branch April 4, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embedded Embedded Swift SIL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants