[6.2] embedded: fix two problems in the SILLinker #80579
Merged
+92
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eeckstein
commented
Apr 7, 2025
eeckstein
commented
- Explanation: This fixes two problem in the SILLinker, which resulted in unresolved linker symbols in embedded mode. The first fix is to de-serialize base protocol witness tables. The second fix is to de-serialize Executor witness tables for the ExecutorRef builtins
- Risk: Low. It only affects embedded swift when working with concurrency or using existentials with base protocols.
- Testing: Tested by lit tests.
- Issue: rdar://148538336
- Reviewer: @MaxDesiatov
- Main branch PR: embedded: fix two problems in the SILLinker #80530
…embedded mode Fixes unresolved symbol linker errors or compiler crashes rdar://148538336
…builtins Fixes unresolved symbol linker errors in embedded mode. rdar://148538336
eeckstein
requested review from
shahmishal,
mikeash,
al45tair,
jckarter,
rjmccall and
AnthonyLatsis
as code owners
eeckstein
requested review from
MaxDesiatov
and removed request for
jckarter,
mikeash,
rjmccall,
shahmishal,
al45tair and
AnthonyLatsis
|
@swift-ci test |
tbkka
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.