[cxx-interop] Remove -fno-rtti workaround in tests
#80531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`-Xcc -fno-rtti` flags were added to these tests back in 2020 when we could not properly link with the C++ stdlib. This should hopefully speed up these tests, which are currently among the slowest tests in the project.
egorzhdan
requested review from
zoecarver,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro and
hnrklssn
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
Xazax-hun
approved these changes
Apr 4, 2025
|
@swift-ci please smoke test macOS |
j-hui
approved these changes
Apr 4, 2025
|
@swift-ci please smoke test macOS |
fahadnayyar
approved these changes
Apr 6, 2025
egorzhdan
force-pushed
the
egorzhdan/test-rtti-enable
branch
from
c656426 to
7741a4d
Compare
|
@j-hui sounds good, I switched to the new flag |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Xcc -fno-rttiflags were added to these tests back in 2020 when we could not properly link with the C++ stdlib.This should hopefully speed up these tests, which are currently among the slowest tests in the project.