Skip to content

[cxx-interop] Switch to non-experimental flag in tests #80539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

egorzhdan
Copy link
Contributor

This gets rid of the flag deprecation warning that was printed for enable-experimental-cxx-interop.

Inspired by a comment from @j-hui: #80531 (review)

This gets rid of the flag deprecation warning that was printed for `enable-experimental-cxx-interop`.
@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Apr 4, 2025
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Contributor

@j-hui j-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had no idea this existed (should we be using it?) but I am in favor of this change.

@egorzhdan
Copy link
Contributor Author

@j-hui I think I'd personally be in favor of spelling out these flags explicitly, as long as it isn't a lot of boilerplate, but we have a lot of tests that are using target-interop-build-swift. So I don't have a strong opinion here.

@egorzhdan egorzhdan enabled auto-merge April 4, 2025 15:40
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test macOS

@egorzhdan egorzhdan merged commit 1f80e50 into main Apr 4, 2025
3 checks passed
@egorzhdan egorzhdan deleted the egorzhdan/test-switch-flag branch April 4, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants