Fix GenericSpecializer for addressable parameters. #80577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atrick
requested review from
eeckstein,
jckarter,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci test |
Addressable parameters must remain indirect. Incidentally also fixes an obvious latent bug in which all specialization was disabled if any metatypes could not be specialized. Fixes rdar://145687827 (Crash of inline-stored Span properties with optimizations)
atrick
force-pushed
the
addressable-escape
branch
from
0a02f71 to
ef7c053
Compare
|
@swift-ci smoke test |
jckarter
approved these changes
Apr 7, 2025
atrick
force-pushed
the
addressable-escape
branch
from
ef7c053 to
6073d59
Compare
|
@swift-ci test |
atrick
force-pushed
the
addressable-escape
branch
from
6073d59 to
923de73
Compare
|
@swift-ci test |
atrick
force-pushed
the
addressable-escape
branch
from
923de73 to
5914369
Compare
|
@swift-ci test |
|
@swift-ci smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressable parameters must remain indirect.
Incidentally also fixes an obvious latent bug in which all specialization was disabled if any metatypes could not be specialized.
Fixes rdar://145687827 (Crash of inline-stored Span properties with optimizations)