[6.2] Fix GenericSpecializer for addressable parameters. #80652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 6898e33)
(cherry picked from commit 501abb0)
Addressable parameters must remain indirect. Incidentally also fixes an obvious latent bug in which all specialization was disabled if any metatypes could not be specialized. Fixes rdar://145687827 (Crash of inline-stored Span properties with optimizations) (cherry picked from commit 935b5e7)
(cherry picked from commit f5d7c03)
(cherry picked from commit 5914369)
tbkka
approved these changes
Apr 8, 2025
|
@swift-ci test |
|
swift crashes on Windows while building the sourcekit-lsp package. |
|
@swift-ci test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressable parameters must remain indirect.
Incidentally also fixes an obvious latent bug in which all specialization was disabled if any metatypes could not be specialized.
Fixes rdar://145687827 (Crash of inline-stored Span properties with optimizations)
main PR: #80577