-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[sil-capture-propagation] Support generic partial_apply instructions #8081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sil-capture-propagation] Support generic partial_apply instructions #8081
Conversation
…ct-to-direct conversions of parameters and results This is required by the capture propagation pass. Indirect-to-direct conversions are still performed by default.
@swift-ci please smoke test |
@swift-ci please smoke benchmark |
Build comment file:Optimized (O) Regression (1)
Improvement (27)
No Changes (154)
Regression (2)
Improvement (1)
No Changes (179)
|
Assuming those benchmark results are not lying that's an impressive speedup! Once partial specialization of generics lands, we should brainstorm how to refactor the closure passes to support partial specialization here as well. |
@slavapestov I actually doubt these results. I haven't seen the same numbers locally, IIRC. |
@swift-ci please benchmark |
Build comment file:Optimized (O) Regression (1)
Improvement (0)No Changes (183)
Regression (1)
Improvement (0)No Changes (183)
|
Build comment file:Optimized (O) Regression (0)Improvement (0)No Changes (184)
Regression (0)Improvement (1)
No Changes (183)
|
Reverted. This broke in CI. |
|
No description provided.