SIL optimizations: Implement the new API for analysis invalidation. #8083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
atrick
approved these changes
Mar 14, 2017
| } | ||
|
|
||
| virtual void invalidate(SILFunction *F, InvalidationKind K) { invalidate(K); } | ||
| /// Invalidate all of the information for a specific function. | ||
| virtual void invalidate(SILFunction *F, InvalidationKind K) override { } |
There was a problem hiding this comment.
Comment: explain why this does nothing.
| virtual void invalidate(SILFunction *F, InvalidationKind K) override { } | ||
|
|
||
| /// Notify the analysis about a newly created function. | ||
| virtual void notifyAddFunction(SILFunction *F) override { } |
There was a problem hiding this comment.
Comment: explain why this does nothing.
|
|
||
| /// Notify the analysis about a function which will be deleted from the | ||
| /// module. | ||
| virtual void notifyDeleteFunction(SILFunction *F) override { }; |
There was a problem hiding this comment.
Comment: explain why this does nothing.
| @@ -34,6 +34,22 @@ class DestructorAnalysis : public SILAnalysis { | |||
| /// Returns true if destruction of T may store to memory. | |||
| bool mayStoreToMemoryOnDestruction(SILType T); | |||
|
|
|||
| /// No invalidation is needed. | |||
There was a problem hiding this comment.
Comment: explain why no invalidation is needed.
| @@ -983,17 +971,35 @@ class CapturePromotionPass : public SILModuleTransform { | |||
| processFunction(&F, Worklist); | |||
|
|
|||
| if (!Worklist.empty()) { | |||
There was a problem hiding this comment.
What is this if-condition for?
There was a problem hiding this comment.
Oops. It should be removed
Get rid of the utility class ClosureSpecializer. NFC.
There are now separate functions for function addition and deletion instead of InvalidationKind::Function. Also, there is a new function for witness/vtable invalidations. rdar://problem/29311657
…SignatureOpts and GenericSpecializer anymore. Because now the BasicCalleeAnalysis is not invalidated anyway by these optimizations. It’s only invalidated by DeadFunctionElimination.
Thanks @atrick for reviewing!
eeckstein
force-pushed
the
silanalysis-invalidation-api
branch
from
de928a3 to
0e068ea
Compare
|
@swift-ci Please smoke test and merge |
1 similar comment
|
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are now separate functions for function addition and deletion instead of InvalidationKind::Function.
Also, there is a new function for witness/vtable invalidations.
rdar://problem/29311657
Also:
No need to preserve BasicCalleeAnalysis from invalidation in FunctionSignatureOpts and GenericSpecializer anymore.
Because now the BasicCalleeAnalysis is not invalidated anyway by these optimizations.
It’s only invalidated by DeadFunctionElimination.