SafeInteropWrapper crashes with 'cgImage.width' #80948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
rapidsna
force-pushed
the
eng/PR-149691207
branch
from
a8cab09 to
1c9cfa1
Compare
rapidsna
changed the title
|
@swift-ci smoke test |
rapidsna
requested review from
zoecarver,
egorzhdan,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro,
hnrklssn,
beccadax and
ian-twilightcoder
as code owners
hnrklssn
reviewed
Apr 23, 2025
lib/ClangImporter/ImportDecl.cpp
Outdated
| @@ -9159,6 +9159,8 @@ void ClangImporter::Implementation::swiftify(FuncDecl *MappedDecl) { | |||
| returnHasLifetimeInfo = true; | |||
| } | |||
| for (auto [index, clangParam] : llvm::enumerate(ClangDecl->parameters())) { | |||
| if (index >= MappedDecl->getParameters()->size()) | |||
There was a problem hiding this comment.
While this protects against the crash, I don't think we want to apply _SwiftifyImport in any case where there's a parameter mismatch, since they could all be off by 1. I would suggest changing it to an early exit before the loop:
if (ClangDecl->parameters()->size() != MappedDecl->getParameters()->size())
return;
cgImage.width calls the C function, CGImageGetWidth(CGImageRef). Swift representation and Clang representation of this function seem to have a parameter number mismatch, causing swiftify function to crash. rdar://149691207
rapidsna
force-pushed
the
eng/PR-149691207
branch
from
1c9cfa1 to
af8579f
Compare
|
@swift-ci smoke test |
hnrklssn
approved these changes
Apr 24, 2025
Xazax-hun
approved these changes
Apr 24, 2025
|
@swift-ci smoke test |
rapidsna
force-pushed
the
eng/PR-149691207
branch
from
8f706b4 to
66e0486
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
@swift-ci smoke test |
rapidsna
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cgImage.width calls the C function, CGImageGetWidth(CGImageRef).
Swift representation and Clang representation of this function
seem to have a parameter number mismatch, causing swiftify function
to crash.
rdar://149691207