SafeInteropWrapper crashes with 'cgImage.width' #81075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgImage.width calls the C function, CGImageGetWidth(CGImageRef). Swift representation and Clang representation of this function seem to have a parameter number mismatch, causing swiftify function to crash. rdar://149691207 (cherry picked from commit af8579f)
|
@swift-ci test |
Xazax-hun
approved these changes
Apr 24, 2025
DougGregor
approved these changes
Apr 24, 2025
|
CI is blocked on a clang crash: |
|
@swift-ci test |
|
@swift-ci test macOS |
|
@swift-ci test |
rapidsna
force-pushed
the
eng/PR-149691207-release/6.2
branch
from
9a5c6ee to
a9d184b
Compare
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
rapidsna
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: cgImage.width calls the C function, CGImageGetWidth(CGImageRef). Swift representation creates it as a getter function, without treating "self" as an additional parameter, and therefore the parameter numbers mismatch between Clang and Swift. This caused the swiftly function to crash.
Scope: The code affected by this change is under an experimental flag, SafeInteropWrappers. Thus, this won't break any existing code.
Issues: rdar://149691207
Original PRs: SafeInteropWrapper crashes with 'cgImage.width' #80948
Risk: The risk is very low. This is an experimental feature SafeInteropWrapper, which isn't used yet.
Testing: Verified with the regression test that triggered the crash and local testing.
Reviewers: @hnrklssn @Xazax-hun