6.2: [MoveOnlyChecker] Don't complete phis. #81574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply the MoveOnlyAddressChecker change from swiftlang#73358 to the MoveOnly[Value]Checker. After 7713eef, before running value checking, all lifetimes in the function are completed. That doesn't quite work because lifetime completion expects not to encounter reborrows or their adjacent phis. rdar://151325025
|
@swift-ci please test |
tbkka
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fix a compiler crash caused by completing certain lifetimes during move checking.
Apply the fix from #73359 to the move-only object checker.
Move-only checking relies on the completeness of lifetimes of interest. But lifetime completion doesn't handle phis. So bail out of attempts to complete their lifetimes.
This will become irrelevant when lifetimes are complete throughout OSSA.
Scope: Affects move-only code.
Issue: rdar://151325025
Original PR: #81566
Risk: Low, an analogous change was applied to the address checker in release/6.0.
Testing: Added test.
Reviewer: Andrew Trick ( @atrick )