[TypeLowering] Record packs used in signatures. #81581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-chandler
force-pushed
the
rdar147207926
branch
from
d829c58 to
f145271
Compare
To determine whether an instruction may require pack metadata, the types of its operands are examined. Previously, the top level type was checked for having a pack in its signature, and the whole type was checked for having a type anywhere in its layout (via TypeLowering). This didn't account for the case where the metadata was required for a resilient type which uses a pack in its signature. Here, during type lowering, a type having a pack in its signature is counted towards the type having a pack. Fixes a compiler crash. rdar://147207926
nate-chandler
force-pushed
the
rdar147207926
branch
from
f145271 to
aa49b85
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please apple silicon benchmark |
|
@swift-ci please test macos platform |
|
@swift-ci please test linux platform |
1 similar comment
|
@swift-ci please test linux platform |
hamishknight
added a commit
to hamishknight/swift
that referenced
this pull request
May 22, 2025
…207926" This reverts commit 3934652.
nate-chandler
added a commit
to nate-chandler/swift
that referenced
this pull request
Jun 6, 2025
Every `LowerType::visit*` function eventually calls through to a `LowerType::handle*` function. After swiftlang#81581, every `LowerType::handle*` needs to set the `hasPack` flag based on the passed-in type by calling `mergeHasPack`. Add the missing call in the `handleAggregateByProperties` function. rdar://152580661
nate-chandler
added a commit
to nate-chandler/swift
that referenced
this pull request
Jun 6, 2025
Every `LowerType::visit*` function eventually calls through to a `LowerType::handle*` function. After swiftlang#81581, every `LowerType::handle*` needs to set the `hasPack` flag based on the passed-in type by calling `mergeHasPack`. Add the missing call in the `handleAggregateByProperties` function. rdar://152580661
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To determine whether an instruction may require pack metadata, the types of its operands are examined.
Previously, the top level type was checked for having a pack in its signature, and the whole type was checked for having a type anywhere in its layout (via TypeLowering). This didn't account for the case where the metadata was required for a resilient type which uses a pack in its signature.
Here, during type lowering, a type having a pack in its signature is counted towards the type having a pack.
Fixes a compiler crash.
rdar://147207926