Skip to content

[TypeLowering] Record pack used in aggregate signature. #82043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025

Conversation

nate-chandler
Copy link
Contributor

Every LowerType::visit* function eventually calls through to a LowerType::handle* function. After #81581 , every LowerType::handle* needs to set the hasPack flag based on the passed-in type by calling mergeHasPack. Add the missing call in the handleAggregateByProperties function.

rdar://152580661

Every `LowerType::visit*` function eventually calls through to a
`LowerType::handle*` function.  After
swiftlang#81581, every
`LowerType::handle*` needs to set the `hasPack` flag based on the
passed-in type by calling `mergeHasPack`.  Add the missing call in the
`handleAggregateByProperties` function.

rdar://152580661
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nate-chandler
Copy link
Contributor Author

@swift-ci please smoke test

@nate-chandler nate-chandler marked this pull request as ready for review June 6, 2025 18:37
@nate-chandler nate-chandler merged commit 17798c7 into swiftlang:main Jun 6, 2025
3 of 5 checks passed
@nate-chandler nate-chandler deleted the rdar152580661 branch June 6, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants