SIL: Resilient types don't need to be treated as addressable-for-dependencies inside their resilience domain. #81583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
…ndencies inside their resilience domain. Outside of the resilience domain, they have to be treated as opaque and therefore potentially addressable-for-dependencies, but inside of the resilience domain, we may take advantage of knowing the type layout to load indirect parameters out of memory and break the (unnecessary) dependency on a fixed memory location. Fixes rdar://151268401. We do still however have problems when the type is actually `@_addressableForDependencies` inside of its resilience domain (rdar://151500074). I'll fix that in a follow up.
jckarter
force-pushed
the
resilient-types-arent-addressable-inside-resilience-domain
branch
from
da283e2 to
21c1790
Compare
|
@swift-ci Please test |
|
After bisecting, this change appears to cause a crash for the compiler built with This also occurs for I am double-checking the bisect to make sure this is the right change. Would you like a full issue created for this? |
|
Sounds like an issue worth filing. Do you have more information about what configuration you're seeing this bootstrap failure under? |
|
I created #81698. This is reproducible on Linux/x86_64. On double-checking this, it may actually not be this commit, but possibly something the merge for this commit dragged in somehow. Fulsome details are in the issue. |
hamishknight
added a commit
to hamishknight/swift
that referenced
this pull request
May 22, 2025
…pes-arent-addressable-inside-resilience-domain" This reverts commit 10a80f5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outside of the resilience domain, they have to be treated as opaque and therefore potentially addressable-for-dependencies, but inside of the resilience domain, we may take advantage of knowing the type layout to load indirect parameters out of memory and break the (unnecessary) dependency on a fixed memory location. Fixes rdar://151268401.
We do still however have problems when the type is actually
@_addressableForDependenciesinside of its resilience domain (rdar://151500074). I'll fix that in a follow up.