[6.2] SIL: Resilient types don't need to be treated as addressable-for-dependencies inside their resilience domain. #81628
+38
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndencies inside their resilience domain. Outside of the resilience domain, they have to be treated as opaque and therefore potentially addressable-for-dependencies, but inside of the resilience domain, we may take advantage of knowing the type layout to load indirect parameters out of memory and break the (unnecessary) dependency on a fixed memory location. Fixes rdar://151268401. We do still however have problems when the type is actually `@_addressableForDependencies` inside of its resilience domain (rdar://151500074). I'll fix that in a follow up.
|
@swift-ci Please test |
tbkka
approved these changes
May 21, 2025
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Avoids spurious lifetime escape diagnostics in cases where an internal type wraps a public type in a library with library evolution enabled.
Scope: Bug fix.
Issue: rdar://151268401
Original PR: #81583
Risk: Low.
Testing: Swift CI, test case from bug report
Reviewer: TBD