[6.2] Handle unsafe pattern match expressions correctly #81677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an "unsafe" expression is used as the case expression, lift it up so it also covers the synthesized matching expression (`=~`). This eliminates some unsuppressible strict memory safety warnings. Fixes rdar://151731850.
Use the argument type rather than the (potentially generic) parameter type.
|
@swift-ci please test |
|
@swift-ci please test Linux |
tbkka
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
case unsafe someValuewithin aswitch) was not covering the implicitly generated use of the pattern match operator (=~), leading to strict memory safety warnings that could not be suppressed.