Sema: Omit internal from MemberImportVisibility fix-its when appropriate
#81781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
force-pushed
the
member-import-visibility-fixit-implicitly-internal
branch
from
cb75108 to
5c9cad5
Compare
tshortli
requested review from
eeckstein,
jckarter,
zoecarver,
egorzhdan,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro,
hnrklssn,
AnthonyLatsis,
rjmccall and
adrian-prantl
as code owners
|
@swift-ci please smoke test |
…opriate. Omit an explicit access level from `MemberImportVisibility` fix-its under the following conditions: - `InternalImportsByDefault` is enabled. - The required import needs an `internal` access level or lower. - The module is not yet imported explicitly in any other file. Resolves rdar://149577615.
tshortli
force-pushed
the
member-import-visibility-fixit-implicitly-internal
branch
from
5c9cad5 to
dbb1d78
Compare
tshortli
removed request for
jckarter,
Xazax-hun,
egorzhdan,
j-hui,
zoecarver,
eeckstein,
fahadnayyar and
rjmccall
tshortli
removed request for
adrian-prantl,
hnrklssn,
AnthonyLatsis and
susmonteiro
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows |
xymus
reviewed
May 27, 2025
| auto accessLevelForImport = [&]() -> std::optional<AccessLevel> { | ||
| auto maxAccessLevel = sf.getMaxAccessLevelUsingImport(mod); | ||
| if (internalImportsByDefaultEnabled) { | ||
| if (!foundImport && maxAccessLevel <= AccessLevel::Internal) |
There was a problem hiding this comment.
Do we need to check for imports in other files here? In internal-imports-by-default mode the access-level in other files shouldn't mater, the inconsistency diagnostics is disabled in that mode.
There was a problem hiding this comment.
My thinking is that we should follow the style that the developer is already using. If they write explicit access levels on imports of the module in other files, then the fix-it should too (which is handled by the logic below).
xymus
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omit an explicit access level from
MemberImportVisibilityfix-its under the following conditions:InternalImportsByDefaultis enabled.internalaccess level or lower.Resolves rdar://149577615.