[6.2] Sema: Omit internal from MemberImportVisibility fix-its when appropriate
#81782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opriate. Omit an explicit access level from `MemberImportVisibility` fix-its under the following conditions: - `InternalImportsByDefault` is enabled. - The required import needs an `internal` access level or lower. - The module is not yet imported explicitly in any other file. Resolves rdar://149577615.
|
@swift-ci please test |
tshortli
added
🍒 release cherry pick
nkcsgexi
approved these changes
May 27, 2025
tshortli
deleted the
member-import-visibility-fixit-implicitly-internal-6.2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MemberImportVisibilityfix-its whenInternalImportsByDefaultis enabled, the required import needs aninternalaccess level or lower, and the module is not yet imported explicitly in any other file.MemberImportVisibilityis enabled.internalfromMemberImportVisibilityfix-its when appropriate #81781