Skip to content

ASTBridging: Bridge more enums directly #82338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jun 20, 2025
Merged

ASTBridging: Bridge more enums directly #82338

merged 18 commits into from
Jun 20, 2025

Conversation

AnthonyLatsis
Copy link
Collaborator

No description provided.

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

eeckstein
eeckstein reviewed Jun 18, 2025
View reviewed changes
Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

eeckstein
eeckstein reviewed Jun 19, 2025
View reviewed changes
@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test Windows

eeckstein
eeckstein approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

rintaro
rintaro approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member

@rintaro rintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thanks!

@AnthonyLatsis AnthonyLatsis merged commit 1ceeb70 into swiftlang:main Jun 20, 2025
3 checks passed
@AnthonyLatsis AnthonyLatsis deleted the jepa branch June 20, 2025 22:14
@3405691582
Copy link
Member

May be of interest: #82607 -- the EffectsKind bridging seems to cause a crash when bootstrapping and when BRIDGING_MODE=PURE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rintaro rintaro rintaro approved these changes

@eeckstein eeckstein eeckstein approved these changes

@xymus xymus Awaiting requested review from xymus xymus is a code owner

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@jckarter jckarter Awaiting requested review from jckarter jckarter is a code owner

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@CodaFi CodaFi Awaiting requested review from CodaFi CodaFi is a code owner

@DougGregor DougGregor Awaiting requested review from DougGregor DougGregor is a code owner

@hamishknight hamishknight Awaiting requested review from hamishknight hamishknight is a code owner

@rjmccall rjmccall Awaiting requested review from rjmccall rjmccall is a code owner

@artemcm artemcm Awaiting requested review from artemcm artemcm is a code owner

@tshortli tshortli Awaiting requested review from tshortli tshortli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnthonyLatsis @3405691582 @rintaro @eeckstein