Skip to content

[CSSimplify] Prevent missing call fix from recording fixes while ma… #82430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jun 23, 2025

…tching types

We need to be very careful while matching types to test whether a fix is applicable or not to avoid adding extraneous fixes and failing the path early. This is a temporary workaround, the real fix would be to let matchTypes to propagate TMF_ApplyingFixes down.

Resolves: rdar://154010220
Resolves: #82397

@xedin xedin requested a review from hamishknight June 23, 2025 20:38
@xedin xedin requested a review from hborla as a code owner June 23, 2025 20:38
…tching types

We need to be very careful while matching types to test whether a
fix is applicable or not to avoid adding extraneous fixes and failing
the path early. This is a temporary workaround, the real fix would
be to let `matchTypes` to propagate `TMF_ApplyingFixes` down.

Resolves: rdar://154010220
Resolves: swiftlang#82397
@xedin
Copy link
Contributor Author

xedin commented Jun 23, 2025

@swift-ci please smoke test

@xedin
Copy link
Contributor Author

xedin commented Jun 23, 2025

cc @kntkymt

Copy link
Contributor

@hamishknight hamishknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@xedin xedin merged commit b147032 into swiftlang:main Jun 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conversions of Function returning function fail in 6.2
2 participants