[6.2][CSSimplify] Prevent missing call fix from recording fixes while ma…
#82459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tching types We need to be very careful while matching types to test whether a fix is applicable or not to avoid adding extraneous fixes and failing the path early. This is a temporary workaround, the real fix would be to let `matchTypes` to propagate `TMF_ApplyingFixes` down. Resolves: rdar://154010220 Resolves: swiftlang#82397 (cherry picked from commit 7ecb1fd)
|
@swift-ci please test |
bnbarham
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tching types
Explanation:
We need to be very careful while matching types to test whether a fix is applicable or not to avoid adding extraneous fixes and failing the path early. This is a temporary workaround, the real fix would be to let
matchTypesto propagateTMF_ApplyingFixesdown.Resolves: rdar://154010220, Conversions of Function returning function fail in 6.2 #82397
Main Branch PR: [CSSimplify] Prevent
missing callfix from recording fixes while ma… #82430Risk: Low. This is a narrow fix when two function types have different curry levels are matched through an optional injection.
Reviewed By: @hamishknight
Testing: Added new test-cases to the test suite.
(cherry picked from commit 7ecb1fd)