[Serialization] Proof-of-concept: drop overriding methods if the base is missing #8580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...but don't actually try to handle any of them yet. In fact, don't even bother to /produce/ them yet, except for resolving cross-references.
This is important information in a crash trace, so let's make sure to preserve it even as the stack unwinds.
No promises that this is stable yet!
Proof-of-concept for this sort of recovery. In the real world, it's more likely that this will happen due to differences between Swift 3 and Swift 4, rather than changes in what macros are defined, but the latter can still happen when debugging. There's a lot to do here to consider this production-ready. There are no generics involved and no potential circular references, and the /rest/ of the compiler isn't prepared for this either. But it's cool to see it working! Actually recovering is hidden behind the new -enable-experimental-deserialization-recovery option; without it the compiler will continue to eagerly abort.
|
@swift-ci Please test |
|
Build failed |
|
Flaky LLDB test? Non-flaky LLDB test? @swift-ci Please test Linux |
|
Build failed |
|
@swift-ci Please test |
This was referenced Apr 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof-of-concept for this sort of recovery. In the real world, it's more likely that this will happen due to differences between Swift 3 and Swift 4, rather than changes in what macros are defined, but the latter can still happen when debugging.
There's a lot to do here to consider this production-ready. There are no generics involved and no potential circular references, and the rest of the compiler isn't prepared for this either. But it's cool to see it working!
Actually recovering is hidden behind the new -enable-experimental-deserialization-recovery option; without it the compiler will continue to eagerly abort.