Skip to content

More -enable-experimental-deserialization-recovery #8666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jrose-apple
Copy link
Contributor

Improvements to #8580.

  • More tests (still simple ones)
  • Better failure output: if we know we're in a mix-and-match situation, say so before crashing
  • Comment fix

Protocols can't have methods marked 'override'. Class contexts should
always be fine to drop a method that's an override (once the rest of
the world can handle it).
@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test

That is, a Swift 3 target imported into a Swift 4 context or vice
versa. This requires serializing the compatibility mode explicitly,
instead of including it in the textual version string that's only
for debugging.
There's still nothing really complicated going on here, such as an
override that previously satisfied a protocol conformance.
@jrose-apple jrose-apple force-pushed the more-experimental-deserialization-recovery branch from bccb196 to a2e0e27 Compare April 10, 2017 23:39
@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test

@jrose-apple jrose-apple merged commit e26c08f into swiftlang:master Apr 11, 2017
@jrose-apple jrose-apple deleted the more-experimental-deserialization-recovery branch April 11, 2017 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant