AnyObject removal preparations #8770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a 'hasExplicitAnyObject()' bit to ProtocolCompositionType to represent canonical composition types containing '& AnyObject'. Serialize this bit and take it into account when building ExistentialLayouts. Rename ProtocolCompositionType::getProtocols() to getMembers() since it can contain classes now, and update a few usages that need further attention with FIXMEs or asserts. For now, nothing actually constructs these types, and they will trigger arounds asserts. Upcoming patches will introduce support for this.
This replaces a number of usages of KnownProtocolKind::AnyObject, which is soon going away.
There were various problems with layout constraints either being ignored or handled incorrectly. Now that I've exercised this support with an upcoming patch, there are some fixes here. Also, introduce a new ExistentialLayout::getLayoutConstriant() which returns a value for existentials which are class-constrained but don't have a superclass or any class-constrained protocols; an example would be AnyObject, or AnyObject & P for some non-class protocol P. NFC for now, since these layout-constrained existentials cannot be constructed yet.
We forgot to check for a layout constraint here.
… from inheritance clauses For now, NFC, but soon this will be <T : AnyObject>.
A protocol composition with an explicit 'AnyObject' member is now mangled as <protocol list> 'Xl'. For subclass existentials, I changed the mangling from <protocol list> <class> 'XE' to <protocol list> <class> 'Xl'. Not used for anything just yet.
Soon, Swift.AnyObject will become a protocol composition type with no protocols and a class constraint. Since there's no way to write this in the language, cons up an AnyObject type in the Builtin module, so that the standard library can define 'typealias AnyObject = Builtin.AnyObject'.
slavapestov
force-pushed
the
anyobject-removal-preparations
branch
from
6028a3d to
86f3464
Compare
Replace a few usages of TypeBase::getExistentialTypeProtocols(), which I'm going to remove. NFC for now, since subclass existentials are still not fully plumbed through here.
The last usages were in IRGen and they're now gone.
slavapestov
force-pushed
the
anyobject-removal-preparations
branch
from
86f3464 to
0708323
Compare
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test Linux |
|
Build failed |
|
@swift-ci Please test Linux |
|
Build failed |
|
@swift-ci Please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next step in the subclass existential saga after #8685: