Tiny bit more progress on IRGen support for subclass existentials #8788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
slavapestov
commented
Apr 15, 2017
| // -- ObjC-refcounted archetype | ||
| // CHECK: store i8** getelementptr inbounds (i8*, i8** @_T0BOXoWV, i32 17) | ||
| unowned(safe) var os: ObjC | ||
| // CHECK: store i8** getelementptr inbounds (i8*, i8** @_T0BomWV, i32 17) |
There was a problem hiding this comment.
Good catch. It would need to be more conservative.
slavapestov
commented
Apr 15, 2017
| reprTy = IGM.RefCountedPtrTy; | ||
| } else { | ||
| reprTy = IGM.UnknownRefCountedPtrTy; | ||
| } | ||
| } | ||
|
|
||
| // As a hack, assume class archetypes never have spare bits. There's a |
There was a problem hiding this comment.
Yeah, that would work and be a bit more optimal. If we don't already, we should also check the @_unsafe_no_tagged_pointer attribute and whether ObjC interop is enabled at all.
slavapestov
force-pushed
the
subclass-existentials-irgen
branch
from
7831185 to
f30ee81
Compare
jrose-apple
reviewed
Apr 17, 2017
| inheritedType.getType()->getExistentialTypeProtocols(protocols); | ||
| auto layout = type->getExistentialLayout(); | ||
| assert(!layout.superclass && "Should not have a subclass existential " | ||
| "in the inheritance clause of an extension"); |
There was a problem hiding this comment.
This assertion isn't valid; this code runs even when type-checking fails.
There was a problem hiding this comment.
Do you have a test case in mind I can try? I'll address this in an upcoming patch along with the other stuff above about spare bits.
There was a problem hiding this comment.
I think even just the obvious thing would crash:
// compile with -emit-reference-dependencies and check the resulting swiftdeps file
class MyClass {}
extension Int: (MyClass & Equatable) {}
Tested by an upcoming patch that adds IRGen SIL tests.
slavapestov
force-pushed
the
subclass-existentials-irgen
branch
from
f30ee81 to
03373a1
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next step after #8770. Make sure we use the right reference counting style for subclass existentials and class-constrained archetypes. Also, finally remove the
getExistentialTypeProtocols()utility method.