[migrator] Add pass for API type changes #9084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
nkcsgexi
reviewed
Apr 27, 2017
| return {}; | ||
| // FIXME: overrides and conformances. | ||
| return DiffStore.getDiffItems(Buffer.str()); | ||
| ArrayRef<APIDiffItem*> getDiffItems(ValueDecl *VD) { |
There was a problem hiding this comment.
Can we inline this to getRelatedDiffItems so that it is clear getRelatedDiffItems is the only valid function users should call?
This handles optionality changes and type rewrites in function param and return types and constructor param and failability types. Resolves rdar://problem/31766010
nathawes
force-pushed
the
migrator-api-optional-wrap
branch
from
162f8a8 to
8ad6aa4
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci Please smoke test macOS |
|
Looks great! Ship it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles optionality changes and type rewrites in function param/return types and constructor param types and failability.
Resolves rdar://problem/31766010