AST: Move up getBase() to TypeRepr to allow more generic access. NFC #9086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
If we do this, I think we need to come up with a better name. These "bases" are all pretty different from each other, and relying on it would miss things like DictionaryType that splits in two. What are you really trying to do? |
|
(and additionally, is TypeRepr::walk good enough for whatever you're trying to do?) |
|
Basically, we are trying to reduce some code duplication in #9084 . we need a way to generically access the nested level inside of typerepr. |
|
Per discussion with @jrose-apple , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.