[4.0] Diagnostics for Minimal and Complete Patterns #9151
Conversation
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
Wow, this cherry-pick was pretty bad. I'm gonna rebase and try again. |
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test |
| ERROR(non_exhaustive_switch,none, | ||
| "%select{switch must be exhaustive, consider adding |do you want to add }0" | ||
| "%select{missing cases|a default clause}1" | ||
| "%select{:|?}0 %2", (bool, bool, StringRef)) |
There was a problem hiding this comment.
Could you drop the last StringRef? we don't need to duplicate the fixit content.
There was a problem hiding this comment.
Fixing on master first will be awesome. Thank you!
There was a problem hiding this comment.
Ah yeah. That was leftover from when I thought I could combine this fixit with the other one.
Thanks! I'll shoot a quick pull request over and cherry-pick that in here.
|
Weird: If you force-push at a branch that becomes even with the one you're targeting a pull request at, it closes it. |
|
@nkcsgexi These commits are going to be auto-merged anyways, right? I don't think this PR is necessary. |
|
@CodaFi it seems they won't be auto-merged to swift-4.0-branch, shall we revive the pull request? |
Redoes a phase of type checking to validate patterns for minimality and completeness.
Cherry-picked from #8908, #9121, #9155, and #9180.