Skip to content

Remove an unnecessary StringRef from a Space Engine diagnostic #9155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented May 1, 2017

This one is for @nkcsgexi.

@CodaFi CodaFi requested a review from nkcsgexi May 1, 2017 20:27
@CodaFi
Copy link
Contributor Author

CodaFi commented May 1, 2017

@swift-ci please smoke test and merge

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate it. The combining of all missing cases can be overwhelming in diagnostic messages.

@nkcsgexi
Copy link
Contributor

nkcsgexi commented May 1, 2017

@swift-ci please smoke test

@CodaFi
Copy link
Contributor Author

CodaFi commented May 2, 2017

Let's see if the Linux builders are green again.

@swift-ci please smoke test Linux platform

@CodaFi
Copy link
Contributor Author

CodaFi commented May 2, 2017

⛵️

@CodaFi CodaFi merged commit 55b7d17 into swiftlang:master May 2, 2017
@CodaFi CodaFi deleted the redundant-notes-for-redundant-folks branch May 2, 2017 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants