-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Switch back to the old mangling for ObjC runtime names. #9228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci Please smoke test and merge |
What so we need the old remangler for? |
Instead of using the old remangler to remangle the name, can we directly construct the old name? It should be a non-generic class so there are only a couple of cases to handle, and it's a lot less new code. |
@slavapestov No, we also do it for generic classes at runtime. And for that we need the re-mangler. |
That is really unfortunate. I recently added two new node kinds. What will the old remangler do if they appear in the tree? |
It's not that unfortunate because it's only a temporary thing. We'll remove the old remangler again.
The old remangler will not compile. |
To be backward compatible to existing archives created by the NSKeyedArchiver
…ted at runtime. To be backward compatible to existing archives created by the NSKeyedArchiver for generic classes
Check that we can read an archive which was produced with the swift 3.1 compiler
3cc3c4a
to
ddecb64
Compare
@swift-ci Please smoke test and merge |
@swift-ci Please smoke test and merge |
1 similar comment
@swift-ci Please smoke test and merge |
To be backward compatible to existing archives created by the NSKeyedArchiver