Revert "[Mangling] Uniformly use "So" for imported decls." #9233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for Erik's change to go in before running tests. |
jrose-apple
force-pushed
the
revert-So-mangling-change
branch
from
a73ff0e to
368128c
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
This reverts commit 25985cb. For now, we're trying to avoid spurious non-structural changes to the mangling, so that the /old/ mangling doesn't appear to change. That doesn't mean no changes at all, but we can save this one for later.
jrose-apple
force-pushed
the
revert-So-mangling-change
branch
from
368128c to
8e0e91d
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@swift-ci Please clean test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 25985cb, from #8849. For now, we're trying to avoid non-essential non-structural changes to the mangling, so that the old mangling doesn't appear to change. That doesn't mean no changes at all, but we can save this one for later.
Goes with @eeckstein's #9228.