[4.0] [Parse] Don't tell CodeCompletion nonsense about protocol/AT where clauses #9710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…auses. This doesn't give particularly useful information yet (i.e. Self isn't listed, see rdar://problem/31981641 ), but it does stop the completion code from just directly crashing. Fixes rdar://problem/31981486.
|
@swift-ci Please test |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: cherry pick of #9419 . This was misusing an API in a cargo-culted attempt to get better completions for things like
protocol Foo where Se<esc>, which just resulted in crashes. The default completions aren't as helpful as they could be, but are definitely better than just crashing.Scope: Anyone using the new where clauses in Xcode.
Radar: rdar://problem/32256159
Risk: Low: this is removing an incorrectly called, optional function call.
Testing: Swift CI.