[stubs] Autolink against icucore on Darwin. #9780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f1a7c3d.
This reverts commit 0de2425.
Programs using a statically linked build of the standard library need to explicitly link against icucore. There are various potential hacks^Wsolutions to this problem, and this is an attempt at a lesser of evils approach. Emit a linker directive to perform autolinking against icucore on Darwin systems. This allows us to avoid hacking the compiler driver and propagating that hack onto any build systems that don't go through the driver.
|
@swift-ci please test |
jrose-apple
approved these changes
May 19, 2017
|
Build failed |
|
@swift-ci please test Linux Platform |
|
Build failed |
|
@swift-ci please test Linux Platform |
|
Build failed |
|
@swift-ci please test OS X platform |
|
(issue was unrelated and already fixed elsewhere) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Programs using a statically linked build of the standard library need
to explicitly link against icucore. There are various potential
hacks^Wsolutions to this problem, and this is an attempt at a lesser
of evils approach.
Emit a linker directive to perform autolinking against icucore on
Darwin systems. This allows us to avoid hacking the compiler driver
and propagating that hack onto any build systems that don't go through
the driver.