[stubs] Autolink against icucore on Darwin #9781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Programs using a statically linked build of the standard library need to explicitly link against icucore. There are various potential hacks^Wsolutions to this problem, and this is an attempt at a lesser of evils approach. Emit a linker directive to perform autolinking against icucore on Darwin systems. This allows us to avoid hacking the compiler driver and propagating that hack onto any build systems that don't go through the driver.
This reverts commit 0de2425.
This reverts commit f1a7c3d.
|
@swift-ci please test |
jrose-apple
approved these changes
May 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4.0 cherry-pick of #9780
Explanation: Users of statically linked stdlib need to explicitly link against icucore. This adds an auto linking directive to the stubs to provide that.
Scope: Command line targets and those who want to statically link against swift core
Radar (and possibly SR Issue): rdar://problem/32286893
Risk: Low. Only affects static linking and is more robust on Apple platforms than the driver hack from yesterday
Testing: Full CI testing