[pull] swiftwasm from master #1284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Make `recordValueIfActive` short-circuit, returning true on error. Remove booleans tracking whether diagnostics have been emitted.
Add request that resolves the "tangent stored property" corresponding to an original stored property in a `Differentiable`-conforming type. Enables better non-differentiability differentiation transform diagnostics.
Use TangentStoredPropertyRequest in differentiation transform. Improve non-differentiability diagnostics regarding invalid stored property projection instructions: `struct_extract`, `struct_element_addr`, `ref_element_addr`. Diagnose the following cases: - Original property's type does not conform to `Differentiable`. - Base type's `TangentVector` is not a struct. - Tangent property not found: base type's `TangentVector` does not have a stored property with the same name as the original property. - Tangent property's type is not equal to the original property's `TangentVector` type. - Tangent property is not a stored property. Resolves TF-969 and TF-970.
Admit different path separators in DebugInfo tests. These will be used in subsequent changes that enable the directory module layout on non-Darwin platforms.
The new function `swift_compareTypeContextDescriptors` is equivalent to a call through to swift::equalContexts. The implementation it the same as that of swift::equalContexts with the following removals: - Handling of context descriptors of kind other outside of ContextDescriptorKind::Type_First...ContextDescriptorKind::Type_Last. Because the arguments are both TypeContextDescriptors, the kinds are known to fall within that range. - Casting to TypeContextDescriptor. The arguments are already of that type. For now, the new function has "future" availability.
…tyStackTrace. I thought this was me being more standard but I keep on hitting this so I am returning back to an assert(0) version of this. This is only enabled if NDEBUG is set, so this is ok.
…equence [stdlib] Fixes example snippet in Sequence.swift
tests: loosen overly-restrictive test patterns
…ft_compareTypeContextDescriptors
…3339bfb9cead2b6edefb0f5
This dependency is already recorded in the `importInfo`'s `ModuleNames`.
* Don't always give shared linkage to spl functions private functions on specialization were being given shared linkage. Use swift::getSpecializeLinkage to correctly get the linkage for the specialized function based on the linkage of the original function. * Extend AllocBoxToStack to handle apply AllocBoxToStack analyzes the uses of boxes and promotes them to stack if it is safe to do so. Currently the analysis is limited to only a few known users including partial_apply. With this change, the pass also analyzes apply users, where the callee is a local private function. The analysis is recursive and bound by a threshold. Fixes rdar://59070139
The new function swift_compareProtocolConformanceDescriptors calls through to the preexisting code in MetadataCacheKey which has been extracted out from MetadataCacheKey::compareWitnessTables into a new public static function MetadataCacheKey::compareProtocolConformanceDescriptors. The new function's availability is "future" for now.
…ored-property [AutoDiff] Improve invalid stored property projection diagnostics.
[DepScan] NFC: Remove check for OnoneSupport
…ft_compareProtocolConformanceDescriptors
MaxDesiatov
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )