[pull] swiftwasm from main #4091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
mangleOpaqueTypeDecl() used to enable DWARFMangling, which ignores @_originallyDefinedIn, which would in turn break module interfaces. Fixes rdar://problem/86480663.
When we switched this path over to use lazy member loading, a subsequent commit introduced a check that members were canonical. In certain extremely twisty scenarios involving multiple modular frameworks pulling in non-modular headers, this check can fail which results in us silently dropping these members on the floor. It's ultimately correct to only pull in the canonical members, but real-world examples of "system" frameworks evading modularity diagnostics exist so this is strictly a regression. Drop the canonicity check for FieldDecls. rdar://86740970
The verifier checked for `isTypeDependentOperand()` (which was the only NonUse operand case we had so far) instead of OperandOwnership::NonUse.
…d-in-opaque-result-type ASTMangler: Respect @_originallyDefinedIn in mangleOpaqueTypeDecl()
Introduce a new instruction `dealloc_stack_ref ` and remove the `stack` flag from `dealloc_ref`. The `dealloc_ref [stack]` was confusing, because all it does is to mark the deallocation of the stack space for a stack promoted object.
Disable an autodiff test that's causing the linker on Ubuntu 20.04 to crash every so often rdar://87254800
The `Qr` mangling is used to refer to the opaque type within the declaration that produces the opaque type. When there are multiple opaque types, e.g., due to structural or named opaque result types, it does not specify which of the opaque type parameters it refers to. Introduce a new mangling `QR INDEX` for opaque type parameters after the first, retaining the `Qr` mangling for the first opaque type parameter. This way, existing (non-structural) uses of opaque result types retain the same manglings, but uses of structural or named opaque result types (new features) will have distinct manglings. Note that this mangling within a declaration is only used for the declaration itself, and not for references to the opaque type of the declaration, so there is no impact on the runtime demangler.
…stack Rename `dealloc_ref [stack]` and enable StackPromotion for OSSA
…aque-types Introduce a mangling for multiple opaque types within the declaration.
Always Import FieldDecls from Records
…jc-open-function-in-extension [Diagnostics] Add diagnostic for non-objc functions declared as open inside extension
MaxDesiatov
approved these changes
Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )