Update PHP to 8.0 #1266
Update PHP to 8.0 #1266
Conversation
| @@ -10,11 +10,11 @@ | |||
| "symfony/polyfill-php73": "*" | |||
| }, | |||
| "require": { | |||
| "php": "^7.3 || ^8.0", | |||
| "php": "^8.0", | |||
There was a problem hiding this comment.
I'd keep ^7.3 support as well, why not?
There was a problem hiding this comment.
Well, the PR says it wants to migrate the demo to use attributes, meaning that this bump is the main goal of the PR
There was a problem hiding this comment.
Exactly. First thing to do is to update php, second PR that I want to prepare will be related to attributes.
There was a problem hiding this comment.
Hm, probably it makes sense to do that attributes change in this PR? It would be more obvious why we need that PHP upgrade. Otherwise, I don't like dropping ^7.3 support just for something that will happen in the future
There was a problem hiding this comment.
For me no problem, just let me know if that’s your final decision. 😄
|
@igornast thanks for your contribution! However, the Symfony Demo project aligns strictly to the current stable Symfony version. That means that we can only make these changes when Symfony 6.0 is released (in just a few weeks!) because it requires PHP 8.0.2. Please also note that there's a previous PR (#1169) similar to this one. In any case, don't close your PR yet. Let's keep in "on hold" and we'll decide which one to merge when Symfony 6.0 is released. Thanks! |
Hi,
As PHP 8.0 was release almost a year ago, I thought that it would be nice to start using it's features for example attributes. Before I would be able to prepare attributes PR for it, demo's composer should be updated to support php:^8.0.
Thanks for feedback and thoughts