Skip to content

Update PHP to 8.0 #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Update PHP to 8.0 #1266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5276026
Update PHP to 8.0
igornast Oct 8, 2021
c75dc49
Update PHP to 8.0
igornast Oct 8, 2021
dcd30d6
Update github workflows, remove php 7.* support
igornast Oct 8, 2021
5724f81
Update entities and controllers, replace annotations with attributes
igornast Oct 12, 2021
6e743c2
Merge branch 'symfony:main' into main
igornast Oct 12, 2021
7116e8d
CSFixer fix, phpstan errors fix
igornast Oct 13, 2021
a8eaa84
phpstan errors fix
igornast Oct 14, 2021
fd2f6ef
phpstan errors fix
igornast Oct 14, 2021
aefff6f
phpstan errors fix
igornast Oct 14, 2021
30929e5
phpstan errors fix
igornast Oct 14, 2021
ff209cf
phpstan errors fix
igornast Oct 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php-version: ['7.4']
php-version: ['8.0']

steps:
- name: "Checkout code"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
strategy:
matrix:
operating-system: ['ubuntu-latest']
php-version: ['7.3', '7.4', '8.0']
php-version: ['8.0']
include:
- operating-system: 'macos-latest'
php-version: '8.0'
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ to develop applications following the [Symfony Best Practices][1].
Requirements
------------

* PHP 7.3 or higher;
* PHP 8.0 or higher;
* PDO-SQLite PHP extension enabled;
* and the [usual Symfony application requirements][2].

Expand Down
8 changes: 4 additions & 4 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@
"symfony/polyfill-php73": "*"
},
"require": {
"php": "^7.3 || ^8.0",
"php": "^8.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep ^7.3 support as well, why not?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the PR says it wants to migrate the demo to use attributes, meaning that this bump is the main goal of the PR

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly. First thing to do is to update php, second PR that I want to prepare will be related to attributes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, probably it makes sense to do that attributes change in this PR? It would be more obvious why we need that PHP upgrade. Otherwise, I don't like dropping ^7.3 support just for something that will happen in the future

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me no problem, just let me know if that’s your final decision. 😄

"ext-pdo_sqlite": "*",
"composer/package-versions-deprecated": "^1.8",
"doctrine/doctrine-bundle": "^2.0",
"doctrine/doctrine-migrations-bundle": "^3.0",
"doctrine/doctrine-migrations-bundle": "^3.1",
"doctrine/orm": "^2.6",
"erusev/parsedown": "^1.6",
"sensio/framework-extra-bundle": "^6.1",
Expand All @@ -30,8 +30,8 @@
"symfony/mailer": "^5.3",
"symfony/monolog-bundle": "^3.1",
"symfony/polyfill-intl-messageformatter": "^1.12",
"symfony/security-bundle": "^5.3",
"symfony/runtime": "^5.3",
"symfony/security-bundle": "^5.3",
"symfony/string": "^5.3",
"symfony/translation": "^5.3",
"symfony/twig-pack": "^1.0",
Expand All @@ -55,7 +55,7 @@
},
"config": {
"platform": {
"php": "7.3"
"php": "8.0"
},
"preferred-install": {
"*": "dist"
Expand Down
Loading