-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Upgrade the Demo Application to Symfony 3.1 #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"incenteev/composer-parameter-handler" : "^2.0", | ||
"ircmaxell/password-compat" : "^1.0", | ||
"leafo/scssphp" : "^0.4", | ||
"patchwork/jsqueeze" : "^1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest also migrating to version 2
|
the |
Given the 2 above issues, I suspect you did the |
In eba83d9 you can see that I reverted some changes related to logs and DB and that were introduced to make this app more Heroku-friendly:
|
Have you checked the logs to see what the error is ? It would be great to identify the bug rather than just saying it is buggy and avoiding its usage. |
@stof you are right. I apologize! I didn't want to sound harsh. Here are the details. With this config: doctrine:
dbal:
driver: "pdo_sqlite"
path: "%kernel.root_dir%/../var/data/blog.sqlite" The app works in With this other config: parameters:
database_url: 'sqlite:///%kernel.root_dir%/../var/data/blog.sqlite'
doctrine:
dbal:
url: "%database_url%" Every page shows a
|
that looks weird. |
It seems like it creates a new database instead of using an existing one |
|
This is ready for the final review. Thanks! |
@@ -14,7 +14,7 @@ set_time_limit(0); | |||
/** | |||
* @var Composer\Autoload\ClassLoader $loader | |||
*/ | |||
$loader = require __DIR__.'/autoload.php'; | |||
$loader = require __DIR__.'/../app/autoload.php'; | |||
|
|||
$input = new ArgvInput(); | |||
$env = $input->getParameterOption(array('--env', '-e'), getenv('SYMFONY_ENV') ?: 'dev'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use a new array syntax. This converter can help you https://github.com/thomasbachem/php-short-array-syntax-converter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree ... but let's do that in a separate PR to not complicate this one too much. In fact, let's push PHP to use as many PHP 5.5 features as we can, not only the short array syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javiereguiluz, ok
Let's merge this change to test it a bit before releasing the new version of the demo app. Thanks! |
This fixes #337.