-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Upgrade the Demo Application to Symfony 3.1 #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
abf11e3
Removed PHP 5.3 and 5.4 from Travis
javiereguiluz 549da14
Fixes after the first review
javiereguiluz ee03014
Fixed the phpunit script
javiereguiluz 6ec50f8
Updated dependencies
javiereguiluz 065983b
More changes
javiereguiluz 2d0ba15
Moved the PHPUnit configuration file
javiereguiluz a55d6ce
Updated the .gitignore file
javiereguiluz e381fa0
Moved the app/* dirs to var/*
javiereguiluz 9e809f6
Removed unneeded files
javiereguiluz 951e84c
Updated the logs and cache dirs location
javiereguiluz 1dafbca
Updated the autoload file
javiereguiluz 2591552
Updated the prod front controller
javiereguiluz 0e82427
Updated the PHPUnit config
javiereguiluz e12842b
Updated dependencies
javiereguiluz cda6fa3
Fixed tests for Appveyor
javiereguiluz 203e69e
Fixed PHPUnit config
javiereguiluz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,16 @@ | ||
/app/config/parameters.yml | ||
/app/bootstrap.php.cache | ||
/app/cache/* | ||
/app/logs/* | ||
!app/cache/.gitkeep | ||
!app/logs/.gitkeep | ||
/build/ | ||
/phpunit.xml | ||
/var/* | ||
!/var/cache | ||
/var/cache/* | ||
!var/cache/.gitkeep | ||
!/var/logs | ||
/var/logs/* | ||
!var/logs/.gitkeep | ||
!/var/sessions | ||
/var/sessions/* | ||
!var/sessions/.gitkeep | ||
!var/SymfonyRequirements.php | ||
/vendor/ | ||
/bin/ | ||
/composer.phar | ||
web/bundles/whiteoctoberpagerfanta | ||
/web/bundles/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use a new array syntax. This converter can help you https://github.com/thomasbachem/php-short-array-syntax-converter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree ... but let's do that in a separate PR to not complicate this one too much. In fact, let's push PHP to use as many PHP 5.5 features as we can, not only the short array syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javiereguiluz, ok