-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Adding debug pack. #717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding debug pack. #717
Conversation
This PR was merged into the 1.0-dev branch. Discussion ---------- [Proposal] Sorts symfony.lock entries. Not sure if You guys would like that. This issue is most visible when removing and adding bundles at the same time. Happened to me when working on symfony/demo#717. Commits ------- 7bf407e Sorts symfony.lock entries.
Since my PR to However, in light of @javiereguiluz comment in my previous PR - #716 (comment), I will close this PR if You decide to wait till unfolding Also |
@phpeek Don't wait for the unfolding of the packs. Sorted lock files are useful anyway. |
@jkufner Granted. :) However, my PR introduces more "opinionated" change which is configuring |
@phpeek thanks for this. Don't worry about the lock file diff. About the other changes:
|
@javiereguiluz Very good points ! I'll close this PR and submit new one with Then, I'll look into removing |
I had to edit
symfony.lock
by hand in order to make diff not too scary.It would be an awesome feature to have
symfony.lock
sorted alphabetically as it is happening withcomposer.lock
. :(There's still
TODO
item in monologEasyCorp\EasyLog\EasyLogHandler
handler on how to solve configuring it which I think might be a blocker for introducingdebug-pack
here. I've solved it in a way I'm usingdebug-pack
in my project.