Skip to content

Adding debug pack. #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Adding debug pack. #717

wants to merge 6 commits into from

Conversation

phpeek
Copy link
Contributor

@phpeek phpeek commented Dec 2, 2017

I had to edit symfony.lock by hand in order to make diff not too scary.

It would be an awesome feature to have symfony.lock sorted alphabetically as it is happening with composer.lock. :(

There's still TODO item in monolog EasyCorp\EasyLog\EasyLogHandler handler on how to solve configuring it which I think might be a blocker for introducing debug-pack here. I've solved it in a way I'm using debug-pack in my project.

fabpot added a commit to symfony/flex that referenced this pull request Dec 3, 2017
This PR was merged into the 1.0-dev branch.

Discussion
----------

[Proposal] Sorts symfony.lock entries.

Not sure if You guys would like that.

This issue is most visible when removing and adding bundles at the same time. Happened to me when working on symfony/demo#717.

Commits
-------

7bf407e Sorts symfony.lock entries.
@phpeek
Copy link
Contributor Author

phpeek commented Dec 3, 2017

Since my PR to symfony/flex has been accepted by @fabpot - symfony/flex#222 and released in https://github.com/symfony/flex/releases/tag/v1.0.44, I've decided to regenerate symfony.lock so that it is now sorted. This is gonna make reviewing symfony.lock diffs easier.

However, in light of @javiereguiluz comment in my previous PR - #716 (comment), I will close this PR if You decide to wait till unfolding *-packs dependencies in place is released.

Also composer.lock was conflicting so I've issued composer update to rehash it and updated symfony/flex and sensio/framework-extra-bundle.

@jkufner
Copy link
Contributor

jkufner commented Dec 4, 2017

@phpeek Don't wait for the unfolding of the packs. Sorted lock files are useful anyway.

@phpeek
Copy link
Contributor Author

phpeek commented Dec 4, 2017

@jkufner Granted. :) However, my PR introduces more "opinionated" change which is configuring easylog handler for dev's environment monolog configuration. This is currently marked to as TODO in easy-log-handler's recipe - https://github.com/symfony/recipes/blob/master/easycorp/easy-log-handler/1.0/config/packages/dev/easy_log_handler.yaml#L6 :(

@javiereguiluz
Copy link
Member

@phpeek thanks for this. Don't worry about the lock file diff. About the other changes:

@phpeek
Copy link
Contributor Author

phpeek commented Dec 4, 2017

@javiereguiluz Very good points !

I'll close this PR and submit new one with symfony.lock reordering only.

Then, I'll look into removing monolog dependency. Having plain Symfony logger in demo app is much more natural approach IMO.

@phpeek phpeek closed this Dec 4, 2017
@phpeek phpeek deleted the adding-debug-pack branch December 4, 2017 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants